chore: Moving Replay Integrations to HybridPublic #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brustolin
changed the title
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8e4bc70 | 1229.18 ms | 1240.86 ms | 11.67 ms |
| fff4a70 | 1224.57 ms | 1239.06 ms | 14.49 ms |
| cf97209 | 1234.06 ms | 1251.49 ms | 17.43 ms |
| deeb22c | 1233.90 ms | 1250.19 ms | 16.29 ms |
| 62f06fc | 1213.91 ms | 1238.08 ms | 24.17 ms |
| 9fa5d27 | 1219.86 ms | 1221.71 ms | 1.85 ms |
| 8c50edb | 1212.98 ms | 1233.72 ms | 20.74 ms |
| 4aea556 | 1222.94 ms | 1248.02 ms | 25.08 ms |
| ea73af6 | 1230.96 ms | 1244.98 ms | 14.02 ms |
| c1ca4cb | 1228.71 ms | 1246.23 ms | 17.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8e4bc70 | 21.58 KiB | 625.90 KiB | 604.32 KiB |
| fff4a70 | 21.58 KiB | 707.28 KiB | 685.70 KiB |
| cf97209 | 21.58 KiB | 632.16 KiB | 610.58 KiB |
| deeb22c | 21.58 KiB | 612.11 KiB | 590.53 KiB |
| 62f06fc | 21.58 KiB | 671.30 KiB | 649.72 KiB |
| 9fa5d27 | 20.76 KiB | 393.37 KiB | 372.61 KiB |
| 8c50edb | 20.76 KiB | 432.31 KiB | 411.55 KiB |
| 4aea556 | 22.85 KiB | 411.66 KiB | 388.81 KiB |
| ea73af6 | 20.76 KiB | 425.75 KiB | 404.99 KiB |
| c1ca4cb | 22.30 KiB | 747.52 KiB | 725.22 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4588 +/- ##
=============================================
+ Coverage 91.005% 91.011% +0.005%
=============================================
Files 617 617
Lines 70877 70887 +10
Branches 25302 25296 -6
=============================================
+ Hits 64502 64515 +13
+ Misses 6282 6279 -3
Partials 93 93 see 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
I've tested this branch with getsentry/sentry-react-native#4335 and works as expected. |
|
Can we get a new beta release out this week, RN is waiting for SR fixes made in cocoa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes access to SessionReplayIntegration from Hybrid SDK after #4440 #4486
#skip-changelog